Toolbox Templating Docs

[gambol99]

• adding additional documentation about the toolbox template command

[gambol99]

@KashifSaadat if you can

[gambol99]

/assign @chrislovecnm

[KashifSaadat]

Minor corrections:

• Note --values is a slice so can be defined multiple times
• a use-case for this would be a default configuration which upstream clusters can override.

[KashifSaadat]

Nitpicks:

• Formatting in golang templates is a pain! At the..

[KashifSaadat]

Just little bits of rewording

LGTM!

[chrislovecnm]

@gambol99 / @KashifSaadat it is good to add the label retest-not-required-docs-only so that e2e does not have to run twice.

[chrislovecnm]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [chrislovecnm]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[chrislovecnm]

/retest

[chrislovecnm]

/test pull-kops-e2e-kubernetes-aws

[k8s-github-robot]

Automatic merge from submit-queue.

[ashb]

Sorry to resurrect an old PR, but where does $node come from in this case?

[gambol99]

Arrh .. yes .. I probably shouldn't have included this .. It was a copy and paste from our deployment repo, where we using a common template for all instancegroup .. so our environment file would have something like

node_pools:
- name: compute
  min_size: 2
- name: ingress
  instance: t2.medium

{{- $base := . -}}
{{- $dns_zone := .dns_zone -}}
{{- $enable_bastion := .enable_bastion -}}
{{- $env := env "ENVIRONMENT" -}}
{{- $image := .coreos_version -}}
{{- $instance := .compute_size -}}
{{- $size := .compute_root -}}
{{- $subnets := .compute_subnets -}}
{{- range $index, $node := .node_pools -}}
{{- if $index }}
---
{{ end }}apiVersion: kops/v1alpha2
kind: InstanceGroup
metadata:
  labels:
    kops.k8s.io/cluster: {{ $env }}.{{ $dns_zone }}
  name: {{ $node.name }}
spec:
  {{- if (and (eq $enable_bastion false) ($node.security_groups)) }}
  additionalSecurityGroups:
  {{- range $node.security_groups }}
  - {{ . }}
  {{- end }}
  {{- end }}
  cloudLabels:
    {{- if or (not $node.cloud_labels) (not (hasKey $node.cloud_labels "role")) }}
    role: {{ $node.name }}
    {{- end }}
    {{- if $node.cloud_labels }}
    {{- range $name, $value := $node.cloud_labels }}
    {{ $name }}: {{ $value }}
    {{- end }}
    {{- end }}
  image: {{ default $image $node.image }}
  machineType: {{ default $instance $node.machine_type }}
  maxSize: {{ default "10" $node.max_size }}
  minSize: {{ default "1" $node.min_size }}
  nodeLabels:
    {{- if or (not $node.node_labels) (not (hasKey $node.node_labels "role")) }}
    role: {{ $node.name }}
    {{- end }}
    {{- if $node.node_labels }}
    {{- range $name, $value := $node.node_labels }}
    {{ $name }}: {{ $value }}
    {{- end }}
    {{- end }}
  role: {{ default "Node" $node.role }}
  rootVolumeSize: {{ default $size $node.root_size }}
  subnets:
  {{- $networks := default $subnets $node.subnets }}
  {{- range $networks }}
  {{- if typeIs "map[string]interface {}" . }}
  - {{ .name }}
  {{- else }}
  - {{ . }}
  {{- end }}
  {{- end }}
  {{- if $node.taints }}
  taints:
  {{- range $node.taints }}
  - {{ .}}
  {{- end }}
  {{- end }}
{{- end }}

[ashb]

I thought it might be something like that, and that example was what I was after. Thanks for sharing!