Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for 1.7.1 #3810

Merged
merged 1 commit into from Nov 10, 2017
Merged

Update docs for 1.7.1 #3810

merged 1 commit into from Nov 10, 2017

Conversation

mikesplain
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2017
chrislovecnm
chrislovecnm reviewed Nov 9, 2017
View reviewed changes
docs/examples/basic-requirements.md Outdated
@@ -14,7 +14,7 @@ As root (either ssh directly to root, local root console, or by using "sudo su -
```bash
cd ~
curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl
curl -LO https://github.com/kubernetes/kops/releases/download/1.7.0/kops-linux-amd64
curl -LO https://github.com/kubernetes/kops/releases/download/1.7.1/kops-linux-amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do that curl call for the latest release? I know there is a curl command for that.

Copy link
Contributor Author

@mikesplain mikesplain Nov 9, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislovecnm I'll look at that, although "latest" right now is technically 1.8.0-beta.1, should that be moved to pre-release? Fixed, thanks @justinsb.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @chrislovecnm google seems to say it's only possible if we do something like this

curl -LO https://github.com/kubernetes/kops/releases/download/$(curl -s https://api.github.com/repos/kubernetes/kops/releases/latest | grep tag_name | cut -d '"' -f 4)/kops-linux-amd64

Let me know if that's acceptable!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2017
@mikesplain
Copy link
Contributor Author

mikesplain commented Nov 9, 2017 •
edited

Updated and cleaned up for consistency.

As a side note, I'm adding --devel for our homebrew forumla to make it easier for folks to use our beta releases. I'll follow up with an additional PR and docs once that's merged.

@justinsb
Copy link
Member

/lgtm

For the brew - that sounds good. I think the big problem we had in the past was we were maybe pulling from head, or users were choosing to do so. I like the idea of giving a --devel flag to give a middle-ground :-) (And we're not building pulling from master by default, are we?)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c6071f3 into kubernetes:master Nov 10, 2017
@mikesplain mikesplain deleted the update_docs_for_1.7.1 branch November 10, 2017 13:57
@mikesplain
Copy link
Contributor Author

@justinsb Thanks!

Yep, that happened to me in the past. Nope, we link to the tagged source in brew, then it's bottled up for actual releases to make installs faster. --devel and --HEAD allow to build dev branch or actual git head. I'll add to docs today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm left review comments

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikesplain @justinsb @k8s-github-robot @chrislovecnm @k8s-ci-robot