Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #3864

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Fix spelling #3864

merged 1 commit into from
Nov 17, 2017

Conversation

jonstacks
Copy link
Contributor

Fix spelling of credential in the kops create command.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jonstacks. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2017
@chrislovecnm
Copy link
Contributor

can you regenerate the documentation? make gen-cli docs? I know that travis is failing on that, not sure if it is bombing on anything else

@jonstacks
Copy link
Contributor Author

@chrislovecnm, Sure I can give that a try. Thank you.

@jonstacks
Copy link
Contributor Author

@chrislovecnm,

So it looks like the travis tests for go 1.9 are passing, but failing for go 1.8 with:

k8s.io/kops/util/pkg/tables k8s.io/kops/util/pkg/ui k8s.io/kops/util/pkg/vfs 
  Successfully remade target file `govet'.
   File `verify-gofmt' does not exist.
  Must remake target `verify-gofmt'.
hack/verify-gofmt.sh
  Successfully remade target file `verify-gofmt'.
   File `verify-boilerplate' does not exist.
  Must remake target `verify-boilerplate'.
hack/verify-boilerplate.sh
  Successfully remade target file `verify-boilerplate'.
   File `nodeup' does not exist.
     File `/home/travis/gopath/src/k8s.io/kops/.build/local/nodeup' does not exist.
       Prerequisite `protokube/pkg/gossip/mesh/mesh.proto' is newer than target `protokube/pkg/gossip/mesh/mesh.pb.go'.
      Must remake target `protokube/pkg/gossip/mesh/mesh.pb.go'.
cd /home/travis/gopath/src; protoc --gofast_out=. k8s.io/kops/protokube/pkg/gossip/mesh/mesh.proto
/bin/sh: 1: protoc: not found
make: *** [protokube/pkg/gossip/mesh/mesh.pb.go] Error 127

I also tried remaking the docs with:

$ docker run -it -v "$(pwd):/go/src/k8s.io/kops" golang bash
root@0bfcf9435ce5:/go# cd src/k8s.io/kops/
root@0bfcf9435ce5:/go/src/k8s.io/kops# make gen-cli-docs
KOPS_STATE_STORE= \
KOPS_FEATURE_FLAGS= \
/go/src/k8s.io/kops/.build/local/kops genhelpdocs --out docs/cli

This command exited successfully, however, git status reports no changes.

@chrislovecnm
Copy link
Contributor

@jonstacks known flake with our Makefile

@chrislovecnm
Copy link
Contributor

My total mistake. CI is green.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2017
@jonstacks
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@jonstacks: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrislovecnm
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 1dcc4a0 into kubernetes:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants