-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include encryptionConfig setting within userdata for masters. #3874
Include encryptionConfig setting within userdata for masters. #3874
Conversation
/assign @gambol99 @justinsb @chrislovecnm |
LGTM ... |
CI is. It happy |
CI is not happy |
ebd04b0
to
f0c3ed8
Compare
Whoops, that integration test always catches me out! Should be fixed now @chrislovecnm :) |
Start using bazel for running the tests - vroom |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
When updating the kops
ClusterSpec.EncryptionConfig
setting, akops update cluster / kops rolling-update cluster
mentions no changes required, and so a forced rolling-update is required for the setting to be picked up.Including this in bootstrapscript will add the setting to the user-data for the master nodes only (because it applies to the KubeAPIServer), marking them as requiring a rolling-update.