-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker 17.09.0 version #3881
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Divya Vavili <vavili.divya@gmail.com>
Thanks for your PR! We already include the correct version of docker for Kubernetes 1.8, which version is this for? You are able to set the docker version as well. #sig-node certifies the different docker versions. /assign @justinsb |
From my understanding, the docker version needs to be part of this list to be set explicitly in the cluster spec. This is my use-case - I'm trying to run P3 instances on AWS with nvidia-docker2 and nvidia-docker:2.0 is dependent on 17.09.0 features. Would be good to have this version supported. |
I also hit a couple of issues with P3 instances because of the driver version. Will raise a PR to address that as well. |
Makes sense - thanks @dvavili . @chrislovecnm is right that we don't want to change the default, but you're right that mapping it doesn't change the default and is required for people to specify that docker version (e.g. if you suspect a problem fixed in a later docker version). Apparently we should be using device plugins, BTW, but I haven't really looked into this: /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Add support for docker version 17.09.0 version