Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker 17.09.0 version #3881

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

dvavili
Copy link
Contributor

@dvavili dvavili commented Nov 16, 2017

Add support for docker version 17.09.0 version

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2017
Signed-off-by: Divya Vavili <vavili.divya@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 16, 2017
@chrislovecnm
Copy link
Contributor

Thanks for your PR!

We already include the correct version of docker for Kubernetes 1.8, which version is this for? You are able to set the docker version as well. #sig-node certifies the different docker versions.

/assign @justinsb

@dvavili
Copy link
Contributor Author

dvavili commented Nov 16, 2017

From my understanding, the docker version needs to be part of this list to be set explicitly in the cluster spec. This is my use-case - I'm trying to run P3 instances on AWS with nvidia-docker2 and nvidia-docker:2.0 is dependent on 17.09.0 features. Would be good to have this version supported.

@dvavili
Copy link
Contributor Author

dvavili commented Nov 16, 2017

I also hit a couple of issues with P3 instances because of the driver version. Will raise a PR to address that as well.

@justinsb
Copy link
Member

justinsb commented Nov 18, 2017

Makes sense - thanks @dvavili . @chrislovecnm is right that we don't want to change the default, but you're right that mapping it doesn't change the default and is required for people to specify that docker version (e.g. if you suspect a problem fixed in a later docker version).

Apparently we should be using device plugins, BTW, but I haven't really looked into this:
kubernetes/kubernetes#54011

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 80e4741 into kubernetes:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants