Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version and validation updates for romana networking. #3892

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

cgilmour
Copy link
Contributor

This is a small update for Romana to update the version being installed, and make sure the version validation is correct - it now requires v1.7.x or higher.

It has been tested on AWS only, with a variety of versions:

  • 1.6.0 - error attempting to create cluster, because version is unsupported
  • 1.7.10 - no errors
  • 1.8.3 - no errors

Hoping this can be squeezed into the upcoming 1.8 release.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2017
@Globegitter
Copy link
Contributor

@cgilmour Is updating an exsting cluster from romana preview.2 to GA also supported? (Given it is on k8s 1.7/1.8?)

@cgilmour
Copy link
Contributor Author

@Globegitter yes.
If you're doing it manually, you'd need to update the image labels to v2.0.0, and make sure these two things are in your romana-agent daemonset spec: updateStrategy and additional environment variable

@justinsb
Copy link
Member

/ok-to-test

/lgtm

Thanks for the update @cgilmour !

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2017
@chrislovecnm
Copy link
Contributor

travis is taking the day off. Closing and re-openning

@chrislovecnm
Copy link
Contributor

Grumble ... Travis what is going on :(

@chrislovecnm
Copy link
Contributor

@justinsb PTAL in the AM see if travis gets a clue

@justinsb justinsb closed this Nov 22, 2017
@justinsb justinsb reopened this Nov 22, 2017
@justinsb
Copy link
Member

Aha! Travis says "abuse detected": https://travis-ci.org/kubernetes/kops/requests

Will see if I can figure out what that actually means, and then force-merge after local testing

@justinsb justinsb merged commit 1b58585 into kubernetes:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants