Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kopeio auth #3928

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Update kopeio auth #3928

merged 2 commits into from
Nov 27, 2017

Conversation

justinsb
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2017
@justinsb justinsb added this to the 1.8.0 milestone Nov 26, 2017
@justinsb
Copy link
Member Author

/retest

@justinsb justinsb closed this Nov 26, 2017
@justinsb justinsb reopened this Nov 26, 2017
chrislovecnm
chrislovecnm suggested changes Nov 26, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still owe docs on this. Please include something ... pretty please

@justinsb
Copy link
Member Author

Added docs for the kops side. It's still not really recommended...

@justinsb
Copy link
Member Author

This is the last PR in the 1.8.0 milestone, other than nvme (still not clear what we should do) and other than the channel updates (which don't block a build). Then we can cut the next beta - I think we should but another beta given timings and the amount of churn since beta.1, along with the fact that k8s 1.8 still has that aggregated apiserver bug.

I'm going to attack the 1.8.0 issue backlog next....

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 967ed4a into kubernetes:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @chrislovecnm @k8s-ci-robot @k8s-github-robot