Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flannel error on starting #3956

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

mikesplain
Copy link
Contributor

Fixes an issue where flannel does not startup due to limited resources:

kube-system   21m        21m         4         kube-flannel-ds                                       DaemonSet                                               Warning   FailedPlacement           daemonset-controller                      failed to place pod on "ip-10-25-40-53.ec2.internal": Node didn't have enough resource: cpu, requested: 104857600000, used: 0, capacity: 2000

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2017
@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2017
@mikesplain mikesplain changed the title Fix flannel error on starting WIP Fix flannel error on starting Nov 29, 2017
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2017
@mikesplain mikesplain changed the title WIP Fix flannel error on starting Fix flannel error on starting Nov 29, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2017
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @justinsb @mikesplain

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@mikesplain
Copy link
Contributor Author

Also @justinsb requested we add back -kops.1 to flannel in bootstrapchannelbuilder.

@justinsb
Copy link
Member

/lgtm

Thanks for cleaning up after me @mikesplain

And yes, we need <upstream>-kops.1 so that we can do more kops-specific fixes, without introducing a fake upstream version number...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c98a771 into kubernetes:master Nov 29, 2017
@mikesplain mikesplain deleted the flannel_cpu_bug branch November 29, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants