Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate live project documentation using mkdocs and gh-pages #5085

Merged
merged 2 commits into from
Sep 22, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 1, 2018

Note: to build I need to remove docs/apireference directory. Can we move that directory?

Local test:

rm -rf docs/apireference
make live-docs

open browser localhost:3000

Create a detached branch:

git checkout --orphan gh-pages
git rm -rf .
touch .empty
git add .empty
git commit -m "Initial Commit"

After this step it is possible to build and publish the docs running:

GH_TOKEN=XXXXXX GH_REF=github.com/kubernetes/kops ./hack/publish-docs.sh

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2018
@aledbf aledbf changed the title Generate live project documentation using mkdocs and gh-pages WIP: Generate live project documentation using mkdocs and gh-pages May 1, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2018
@aledbf aledbf force-pushed the docs branch 2 times, most recently from 4697332 to 883b1cf Compare May 1, 2018 12:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2018
@aledbf
Copy link
Member Author

aledbf commented May 1, 2018

/assign @justinsb

@aledbf aledbf changed the title WIP: Generate live project documentation using mkdocs and gh-pages Generate live project documentation using mkdocs and gh-pages May 2, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2018
@aledbf
Copy link
Member Author

aledbf commented May 9, 2018

@justinsb ping

@chrislovecnm
Copy link
Contributor

Note: to build I need to remove docs/apireference directory. Can we move that directory?

Yes we can move it, but we need to fix apireference already. What is the purpose of this PR btw? I know what it does, but in the big picture what value are we getting?

Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, and appreciate the work, but our goal has been to get our docs on kubernetes.io. I do not think other k8s projects are maintaining gh-pages. Thoughts?


.PHONY: live-docs
live-docs:
@docker run --rm -it -p 3000:3000 -v ${PWD}:/docs aledbf/mkdocs:0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aledbf/mkdocs:0.1

I am not a huge fan of pulling in external containers. I know you are maintaining this, but any other options?


| kops version | k8s 1.5.x | k8s 1.6.x | k8s 1.7.x | k8s 1.8.x | k8s 1.9.x |
|--------------|-----------|-----------|-----------|-----------|-----------|
| 1.9.x | Y | Y | Y | Y | Y |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need 1.10 included


git add .
git commit -m "Deploy GitHub Pages"
git push --force --quiet "https://${GH_TOKEN}@${GH_REF}" gh-pages > /dev/null 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we looking at gh-pages? We really need our docs on kubernetes.io :shrug

@aledbf
Copy link
Member Author

aledbf commented May 21, 2018

I like this, and appreciate the work, but our goal has been to get our docs on kubernetes.io.

Who's working on that?

but our goal has been to get our docs on kubernetes.io.

I think the goal should be provide a better UX for user documentation, including search.

I do not think other k8s projects are maintaining gh-pages. Thoughts?

I already do this https://kubernetes.github.io/ingress-nginx/
This was the principal complaint from users (from the survey https://docs.google.com/forms/d/e/1FAIpQLSdcqdfMbuJHeQQe6hB7iU7sf3q9qZlrrXtrwGPlS7sicOpICA/viewform)
Since the publication of the site, we have more metrics about that they search, how they browse the docs and most importantly we now double the number of contributions improving documentation.

@aledbf
Copy link
Member Author

aledbf commented May 21, 2018

@chrislovecnm I can close this PR if the goal is to get the docs on kubernetes.io

@justinsb justinsb added this to the 1.10 milestone Jun 2, 2018
@justinsb justinsb mentioned this pull request Jun 6, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aledbf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: justinsb

If they are not already assigned, you can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member

This is awesome, thank you @aledbf . We'll have to reorg our docs a little, but I think people want to do that anyway. I'm going to go ahead and merge this so we can get the reorg started :-)

@justinsb justinsb merged commit cfe3267 into kubernetes:master Sep 22, 2018
gtrafimenkov added a commit to gtrafimenkov/kops that referenced this pull request Mar 3, 2019
@mikesplain mikesplain mentioned this pull request Sep 20, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants