Addon update heapster

[recollir]

Updated heapster version and added a note about heapster being deprecated.

[mikesplain]

Thanks @recollir!

/ok-to-test
/lgtm

[recollir]

/assign @KashifSaadat

[mikesplain]

@recollir Looks like you've got a conflict, mind rebasing?

[recollir]

/test pull-kops-e2e-kubernetes-aws

[recollir]

@mikesplain rebased. but pull-kops-e2e-kubernetes-aws is flakey again

[justinsb]

What's the source for this? I'm trying to make sense of the version of addon-resizer - 2.1 seems older than 1.8.1

[recollir]

I can't find the source to this, what appeared to be, "newer" version. I will revert it back to the now 1.8.3

[KashifSaadat]

LGTM mostly, just one small change in regards to the version of addon-resizer (recommended version in docs and the current latest is v1.8.1), unless v2.1 is specifically required for some reason?

[KashifSaadat]

Hey @recollir, just wondering if you've had a chance to review the last outstanding comment for this PR in regards to the addon-resizer version?

[recollir]

I was out travelling. Will look at it during the next few days.

[justinsb]

Would love to have this in, but moving it to the 1.11 milestone as 1.10 is imminent

[recollir]

I can't find the source to this, what appeared to be, "newer" version. I will revert it back to the now 1.8.3

[recollir]

I have now reverted the addon-resizer version to 1.8.3 as that version was used in https://github.com/kubernetes/kubernetes/blob/c65f65cf6aea0f73115a2858a9d63fc2c21e5e3b/cluster/addons/cluster-monitoring/google/heapster-controller.yaml#L82

Sorry for the delay. We had a good long summer in Europe with long vacations and travelling.

[KashifSaadat]

Hey @recollir, no problem thanks for making the update :)

The test failures have been fixed in master, you might need to rebase your branch off master for them to disappear.

/retest
/lgtm

[justinsb]

Thanks for the version tweaks @recollir

/approve
/lgtm

Going to force-merge as CI is just upset about the spellchecker and not related to this PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, KashifSaadat, mikesplain, recollir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KashifSaadat,justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[so0k]

this seems to have broken this addon for us:

Nov 01 06:14:44 ip-10-61-92-234 docker[2432]: error loading channel "https://raw.githubusercontent.com/kubernetes/kops/master/addons/monitoring-standalone/addon.yaml": error parsing addons: error converting YAML to JSON: yaml: line 22: did not find expected key
Nov 01 06:14:44 ip-10-61-92-234 docker[2432]: W1101 06:14:44.412313    2466 kube_boot.go:157] error applying channel "monitoring-standalone": error running channels: exit status 1

forking for our 1.9 clusters :/

[KashifSaadat]

Hi @so0k, it looks like the indentation was slightly out in the addon.yaml file. I've fixed this in PR #6032.