Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel Rules go 0.14 #5481

Merged
merged 3 commits into from
Sep 22, 2018
Merged

Bazel Rules go 0.14 #5481

merged 3 commits into from
Sep 22, 2018

Conversation

mikesplain
Copy link
Contributor

Update bazel rules go and gazelle

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 20, 2018
@mikesplain
Copy link
Contributor Author

This shouldn't be merged until releases are cut.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 20, 2018
@mikesplain
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

Awesome - this is actually really important, because there's an important fix for repeatable builds in 0.13. But kops 1.11 I think :-)

@justinsb justinsb added this to the 1.11 milestone Jul 20, 2018
@mikesplain
Copy link
Contributor Author

Agreed!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2018
@mikesplain
Copy link
Contributor Author

This got bigger than I planned. I noticed a few things, we're running gazelle a few different ways so I adjusted that, unless anyone objects.

Also it looks like import path for vendored deps needs to change.

@mikesplain mikesplain changed the title Bazel Rules go 0.13 Bazel Rules go 0.14 Aug 14, 2018
@mikesplain
Copy link
Contributor Author

Bumped to 0.14 since it has been released.

@mikesplain
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@mikesplain
Copy link
Contributor Author

Holding off on bumping to rules-go 0.15.0 since it requires bazel 0.16.0 which hasn't been shipped in homebrew.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2018
@mikesplain
Copy link
Contributor Author

/assign @justinsb

@justinsb
Copy link
Member

Thanks - looks good

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@mikesplain
Copy link
Contributor Author

Thanks @justinsb, looks like something changed upstream and I had to rerun gazelle. Mind lgtming again?

Thanks!

@mikesplain mikesplain mentioned this pull request Sep 17, 2018
Merged
@justinsb
Copy link
Member

Thanks @mikesplain

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@mikesplain: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-verify-bazel 0cf5166 link /test pull-kops-verify-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member

Force-merging and will fix - overlapping PRs!

@justinsb justinsb merged commit a78e792 into kubernetes:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikesplain @justinsb @k8s-ci-robot