Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme compatability matrix for 1.10 #5484

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

mikesplain
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2018
@mikesplain
Copy link
Contributor Author

Putting a hold on this until we're ready to release 1.10

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2018
@mikesplain
Copy link
Contributor Author

/area documentation

| 1.6.x | Y | Y | N | N | N |
| kops version | k8s 1.5.x | k8s 1.6.x | k8s 1.7.x | k8s 1.8.x | k8s 1.9.x | k8s 1.10.x |
|--------------|-----------|-----------|-----------|-----------|-----------|------------|
| 1.10.x | Y | Y | Y | Y | Y | Y |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the README says kops is intended to be backward compatible. but is there a point where we would no longer support a older version of k8s with the newest version of Kops? The idea behind that being that we would then be able to clean up older code. I've also not see anyone testing the older versions (such as 1.5.x) so new code may not actually support those versions?

Just a passing thought.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a balance between the cost of carrying the old branches vs breaking people's clusters (even if those clusters are running versions of k8s that are unsupported).

So far the cost hasn't been too high, but if we came to a point where the cost was high I could see that we would start a deprecation procedure or tell people that they had to use an older version of kops and that they wouldn't be getting bugfixes.

As you say though, it's certainly not a good idea to run e.g. k8s 1.5 with kops today, because it doesn't have nearly the same testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree both thoughts. I think the readme isn't the right place to begin considering this as it takes more time to denote deprecation and decide the course of action.

I've opened an issue to track and figure out if and how we should consider this.

Thanks @justinsb and @rdrgmnzs!

@justinsb justinsb added this to the 1.10 milestone Jul 22, 2018
@mikesplain
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@mikesplain
Copy link
Contributor Author

/cc @rdrgmnzs @justinsb

@rdrgmnzs
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1e417dc into kubernetes:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants