-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Nvidia DevicePlugin GPU Support on AWS #5502
Implemented Nvidia DevicePlugin GPU Support on AWS #5502
Conversation
* Supports DevicePlugin GPU Mode AND Legacy Accelerators GPU Mode
/ok-to-test |
Tagging those who reviewed/commented on prior GPU PR #4971. This PR adds Kops GPU support for kubernetes >= 1.11.0 via DevicePlugins. @115100, @bhack, @chrislovecnm, @erez-rabih, @faheem-cliqz, @flx42, @justinsb, @KashifSaadat, @mikesplain, @mindprince, @richardbrks, @rtluckie |
Is cuda mandatory? |
@bhack Cuda is not mandatory, but included here to follow the same practice as the other GPU hook images. |
@dcwangmit01 ok but I suppose this will duplicate the node storage consumption when we use pod with image derived from nvidia/cuda like Tensorflow etc.. |
FYI this base image doesn't have any CUDA library (apart from |
@flx42 Yes but I meant that in 90% of the cases the next command is to apt-get cuda-* |
I agree CUDA toolkit libraries shouldn't be part of a driver install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Can this be merged, @mikesplain?
Tested and works as expected. Awesome work thanks. |
This is purely additive, so I'm going to merge it in :-) I've added myself a TODO item to build the docker image as part of the kops release and repoint it, so we won't be relying on your docker images @dcwangmit01 ! Thank you so much @dcwangmit01 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcwangmit01, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
===
Rendered Readme Found Here
https://github.com/dcwangmit01/kops/tree/gpu-device-plugins-3/hooks/nvidia-device-plugin
Related Issues:
Related Pull Requests: