Docker installation from tar.gz #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 18.04 doesn't have a package for docker 17.03, but we can still support it by using the tar.gz package. This could be a nice fallback for other operating systems in future, and it might prove to be more reliable than the OS packages. But start with supporting ubuntu 18.04 with older docker versions!
k8s-ci-robot
added
cncf-cla: yes
justinsb
added a commit
to justinsb/test-infra
that referenced
this pull request
Jul 25, 2018
Support in kops is going in in kubernetes/kops#5517
|
This is awesome. Great fix, I knew that was possible in #5394 but wasn't sure the best way to do it on short notice. Great work. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
added a commit
to justinsb/test-infra
that referenced
this pull request
Jul 26, 2018
Support in kops is going in in kubernetes/kops#5517 Adding this as the first entry in config/jobs/kops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 18.04 doesn't have a package for docker 17.03, but we can still
support it by using the tar.gz package.
This could be a nice fallback for other operating systems in future,
and it might prove to be more reliable than the OS packages.
But start with supporting ubuntu 18.04 with older docker versions!