Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel bazel crossbuild kops #5523

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Parallel bazel crossbuild kops #5523

merged 2 commits into from
Jul 29, 2018

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Jul 25, 2018 •
edited
Loading

Should speed up bazel-crossbuild-kops and some cleanup.

At least locally:

time make bazel-crossbuild-kops  
0.42s user 0.38s system 0% cpu 9:03.16 total
# vs
time make bazel-crossbuild-kops
0.36s user 0.46s system 0% cpu 3:53.67 total

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 397c6a3 into kubernetes:master Jul 29, 2018
@mikesplain mikesplain deleted the parallel_bazel-crossbuild-kops branch July 29, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikesplain @chrisz100 @k8s-ci-robot