Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grammar tense issue ran -> run #5538

Closed
wants to merge 5 commits into from
Closed

grammar tense issue ran -> run #5538

wants to merge 5 commits into from

Conversation

ms4720
Copy link
Contributor

@ms4720 ms4720 commented Jul 27, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ms4720
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andrewsykim

If they are not already assigned, you can assign the PR to them by writing /assign @andrewsykim in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2018
@ms4720
Copy link
Contributor Author

ms4720 commented Jul 27, 2018

/assign @andrewsykim

@ms4720
Copy link
Contributor Author

ms4720 commented Jul 27, 2018

/assign @ncdc

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2018
@ncdc
Copy link
Member

ncdc commented Jul 27, 2018

@ms4720 did you mean to assign this to me? I haven't been working on kops.

@ncdc
Copy link
Member

ncdc commented Jul 27, 2018

/unassign

@justinsb
Copy link
Member

/ok-to-test

Looks like it has some extra commits from another PR in this PR, but I think they should drop out as that PR merges

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2018
@justinsb
Copy link
Member

Looks like those other commits aren't going to drop out @ms4720 - would you mind rebasing (or just sending a new PR, which might be even easier!)

@ms4720 ms4720 closed this Jul 28, 2018
@ms4720 ms4720 reopened this Jul 28, 2018
@ms4720 ms4720 closed this Jul 28, 2018
@ms4720 ms4720 mentioned this pull request Jul 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewsykim andrewsykim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ms4720 @k8s-ci-robot @ncdc @justinsb @andrewsykim