Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for etcd-manager output #5547

Merged
merged 1 commit into from
Sep 22, 2018
Merged

Add test for etcd-manager output #5547

merged 1 commit into from
Sep 22, 2018

Conversation

justinsb
Copy link
Member

We need to get this under test coverage so we can start changing it confidently!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2018
@chrisz100
Copy link
Contributor

/retest

@chrisz100
Copy link
Contributor

@justinsb maybe get the headers updated and get it merged? Getting some pr closed would be good I think.

@justinsb
Add test for etcd-manager output
7cf432f 
We need to get this under test coverage so we can start changing it confidently!
@justinsb
Copy link
Member Author

/retest

1 similar comment
@justinsb
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 7cf432f link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member Author

This looks like a problem with etcd2 in k8s 1.13 (or just with etcd); need to get the manager in to get it to pass. Force-merging.

@justinsb justinsb merged commit 666e290 into kubernetes:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinsb @k8s-ci-robot @chrisz100