Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new amazonvpc version 1.1.0 #5561

Closed
wants to merge 1 commit into from
Closed

Using new amazonvpc version 1.1.0 #5561

wants to merge 1 commit into from

Conversation

harshal-shah
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2018
@harshal-shah
Copy link
Contributor Author

/assign @KashifSaadat

Hi Kashif can you please review and approve?

@mikesplain
Copy link
Contributor

I think we'll probably target this for 1.11. We also have this PR in queue for merging once 1.10 is cut. #5290

@chrisz100
Copy link
Contributor

Having this tested doesn’t hurt though...
/ok-to-test
/milestone v1.11
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2018
@justinsb justinsb added this to the 1.11 milestone Aug 14, 2018
@justinsb
Copy link
Member

We can actually merge this now though - because the master branch is 1.11, and we're cherry-picking to 1.10.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@justinsb justinsb removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshal-shah, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@justinsb justinsb added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2018
@justinsb
Copy link
Member

Ooops - didn't see the conflict with #5290. I guess not such a trivial merge :-(

@harshal-shah
Copy link
Contributor Author

@justinsb Yes, it is not that trivial, I overlooked this earlier. Can we update #5290 to use v1.1.0 for k8s 1.8 and above?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2018
@justinsb
Copy link
Member

So I think we've since merged PRs that move this to an even later version. I'll double check though.

Thanks for the contribution though @harshal-shah ... we really need to get these manifests more easily updateable (likely in a bundle)!

@justinsb
Copy link
Member

Confirmed that we seem to have moved past this PR in the interim. Sorry that we couldn't merge it - the sequencing of the PRs was tricky!

Going to close, but do reopen (or open a new PR) if I've missed something. I did spot two small problems - #6095 and #6094

/close

@k8s-ci-robot
Copy link
Contributor

@justinsb: Closed this PR.

In response to this:

Confirmed that we seem to have moved past this PR in the interim. Sorry that we couldn't merge it - the sequencing of the PRs was tricky!

Going to close, but do reopen (or open a new PR) if I've missed something. I did spot two small problems - #6095 and #6094

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@KashifSaadat KashifSaadat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@harshal-shah @mikesplain @chrisz100 @justinsb @k8s-ci-robot @fejta-bot @KashifSaadat