Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure --node-cidr-mask-size into kube-controller-manager #5596

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

robermorales
Copy link
Contributor

Given that some CNI providers like Cilium can read the Node CIDR provisioned by kube-controller-manager, this PR makes a great option to configure a higher ipv4 pool for pods inside every node, just by allowing this flag to be exposed from the manifests.

Including this snippet inside a kops manifest a user can get a mask size for pods different than /24, and so an effective maxPods limit over the default 150. Cilium is only an example in this snippet. The option is generally available and documented in kube-controller-manager.

...
  kubelet:
    maxPods: 4096
  kubeControllerManager:
    nodeCIDRMaskSize: 20
  networking:
    cilium: {}
...

Thanks for considering.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2018
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2018
@justinsb
Copy link
Member

Thanks @robermorales

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, robermorales

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@mikesplain
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@mikesplain
Copy link
Contributor

This should be fixed now

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 8905f5d into kubernetes:master Aug 13, 2018
@robermorales robermorales deleted the node-cidr-mask-size branch August 30, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants