Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS IAM permission to check for volume resize #5597

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Add AWS IAM permission to check for volume resize #5597

merged 1 commit into from
Aug 13, 2018

Conversation

KashifSaadat
Copy link
Contributor

Fixes #5413

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2018
@KashifSaadat
Copy link
Contributor Author

The code that results in this API call is here: https://github.com/kubernetes/kubernetes/blob/v1.10.6/pkg/cloudprovider/providers/aws/aws.go#L1773

@KashifSaadat
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@mikesplain
Copy link
Contributor

mikesplain commented Aug 13, 2018 •
edited
Loading

Thanks @KashifSaadat!
/lgtm
/approve

@KashifSaadat
Copy link
Contributor Author

Thanks @mikesplain :) Seems the bot didn't recognise the lgtm command :(

@mikesplain
Copy link
Contributor

Aww man, lets try again

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KashifSaadat,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KashifSaadat
Copy link
Contributor Author

Awesome thanks!

@justinsb
Copy link
Member

Looks great - thanks! Marking for a backport to 1.10

@k8s-ci-robot k8s-ci-robot merged commit 6e12ed7 into kubernetes:master Aug 13, 2018
@KashifSaadat KashifSaadat deleted the aws-iam-check-volume-resize branch August 14, 2018 07:59
@justinsb justinsb mentioned this pull request Aug 14, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 15, 2018
@k8s-ci-robot
Merge pull request #5617 from justinsb/cherrypick_5597_release-1.10
9a14cfc 
Cherry pick of #5597 onto release-1.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KashifSaadat @mikesplain @k8s-ci-robot @justinsb