Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CoreDNS deployment #5608

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Update CoreDNS deployment #5608

merged 1 commit into from
Aug 15, 2018

Conversation

rajansandeep
Copy link
Contributor

Make CoreDNS run in read-only mode and drop all unneeded privileges

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2018
@rajansandeep
Copy link
Contributor Author

/cc @justinsb

@justinsb justinsb added this to the 1.11 milestone Aug 14, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2018
@KashifSaadat
Copy link
Contributor

Hey @rajansandeep, thanks for the contribution!

For the update to be picked up, you'll need to also update the version referenced for the addon here: https://github.com/kubernetes/kops/blob/1.10.0-beta.1/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L214

You can just add -kops.1 on the end as the actual version hasn't changed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2018
@rajansandeep
Copy link
Contributor Author

@KashifSaadat done!

@rajansandeep
update deployment
7a262f7 
update version
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2018
@KashifSaadat
Copy link
Contributor

Perfect, thank you!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, KashifSaadat, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5ec3418 into kubernetes:master Aug 15, 2018
@rajansandeep rajansandeep deleted the updatedeployment branch August 21, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajansandeep @chrisz100 @KashifSaadat @k8s-ci-robot @justinsb