Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ExperimentalClusterDNS feature flag #5610

Merged

Conversation

justinsb
Copy link
Member

This currently just turns off validation of the kubelet cluster dns
flag, which should allow for experimenting with more complicated DNS
configurations such as local proxies, which may address shortcomings
of DNS retries with UDP.

Issue #5584

This currently just turns off validation of the kubelet cluster dns
flag, which should allow for experimenting with more complicated DNS
configurations such as local proxies, which may address shortcomings
of DNS retries with UDP.

Issue kubernetes#5584
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2018
@justinsb
Copy link
Member Author

/retest

@dcowden
Copy link

dcowden commented Aug 14, 2018

Awesome! Looking forward to 1.11…!

Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c646aad into kubernetes:master Aug 14, 2018
k8s-ci-robot added a commit that referenced this pull request Aug 15, 2018
@igoratencompass
Copy link

@justinsb I see an issue with the clusterDNS option for kubelet. When set under kubelet config like so:

spec:
  kubelet:
    clusterDNS: 169.254.20.10

it gets applied to master kubelets too:

  LaunchConfiguration/master-eu-west-1a.masters.cluster.name
  	UserData            
  	                    	...
  	                    	  set -o pipefail
  	                    	  
  	                    	+ NODEUP_URL=https://kubeupv2.s3.amazonaws.com/kops/1.12.0-beta.2/linux/amd64/nodeup
  	                    	- NODEUP_URL=https://kubeupv2.s3.amazonaws.com/kops/1.12.0-beta.1/linux/amd64/nodeup
  	                    	+ NODEUP_HASH=dc19d42f6580b0be5771004256e41b2ebe29beae
  	                    	- NODEUP_HASH=5c549c46519637485eca345e174d4060db13c75e
  	                    	  
  	                    	  export AWS_REGION=eu-west-1
  	                    	...
  	                    	    cgroupRoot: /
  	                    	    cloudProvider: aws
  	                    	+   clusterDNS: 169.254.20.10
  	                    	-   clusterDNS: 100.64.0.10

which is a problem since I don't have node-local-dns running on the master nodes. I tried to override the setting by putting clusterDNS: 100.64.0.10 in the masterKubelet section but the outcome was same. Shouldn't this setting for kubelet and masterKubelet be independent in case one wants to override it on one type of nodes only?

This is on kops-1.12-beta-2 by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants