Validate that require-kubeconfig is not passed after 1.10 #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
This should alert users that are manually specifying old flags - I suspect that a few of the upgrade failures are due to users that are running with clusters captured from `kops get cluster --full`, and this will detect that. Issue kubernetes#5459
justinsb
force-pushed
the
validate_for_5459
branch
from
7af88e3
to
e10124e
Compare
geojaz
approved these changes
Aug 14, 2018
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geojaz, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@geojaz that's a good idea! Having a few verifications in each release to warn people. If we do I think we'd want some helper functions though! |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 15, 2018
Cherry pick of #5621 onto release-1.10
elafarge
pushed a commit
to elafarge/karch
that referenced
this pull request
Mar 4, 2019
* Starting support of kubernetes v1.10 * Starting support for kops-v1.10 * Remove missplaced comment * ClusterSpec : Remove 'requireKubeconfig' (removed since kops-1.10 of kubernetes/kops#5621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should alert users that are manually specifying old flags - I
suspect that a few of the upgrade failures are due to users that are
running with clusters captured from
kops get cluster --full, andthis will detect that.
Issue #5459