Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deletion of aws resources albs nlbs during delete #5635

Merged
merged 12 commits into from
Sep 21, 2018
Merged

Support for deletion of aws resources albs nlbs during delete #5635

merged 12 commits into from
Sep 21, 2018

Conversation

nareshku
Copy link
Contributor

@nareshku nareshku commented Aug 15, 2018 •
edited
Loading

Fixes #4672

Testing Completed
Create a cluster
Create NLB ingress objects
Delete cluster has deleted the NLBs in AWS.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2018
@nareshku
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@nareshku: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ihoegen
Copy link
Contributor

ihoegen commented Aug 17, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2018
@nareshku
Revert "include dep"
ff2c0d4 
This reverts commit b9c0987.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2018
@nareshku
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 17, 2018
@nareshku
Copy link
Contributor Author

/assign @mikesplain

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2018
shrinandj
shrinandj reviewed Aug 27, 2018
View reviewed changes
cloudmock/aws/mockelbv2/api.go Outdated

type loadBalancer struct {
description elbv2.LoadBalancer
//attributes elbv2.LoadBalancerAttribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If attributes is not needed, feel free to remove it.

shrinandj
shrinandj reviewed Aug 27, 2018
View reviewed changes
pkg/resources/aws/aws.go Outdated
glog.V(2).Infof("Listing all NLBs and ALBs")

request := &elbv2.DescribeLoadBalancersInput{}
// ELB DescribeTags has a limit of 20 names, so we set the page size here to 20 also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment also applicable to NLBs and ALBs? If so, please update the comment.

@nareshku
Copy link
Contributor Author

@shrinandj Thanks for reviewing 👍

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2018
@justinsb
Copy link
Member

This looks great - thank you @nareshku

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, nareshku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2018
@justinsb
Copy link
Member

I started some release notes referencing this change in #5815

@k8s-ci-robot k8s-ci-robot merged commit 2ad8588 into kubernetes:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrinandj shrinandj shrinandj left review comments

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nareshku @k8s-ci-robot @ihoegen @justinsb @shrinandj @mikesplain