Add DEBUGGABLE option to Makefile to compile debuggable bins
#5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
This is great, thanks @lblackstone! Maybe we should throw a note in the development docs so others can use it for troubleshooting? (https://github.com/kubernetes/kops/blob/master/docs/development/building.md#troubleshooting) /ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@mikesplain Added some usage docs |
lblackstone
force-pushed
the
debuggable
branch
from
27432f0
to
6be9dc6
Compare
|
Thanks so much @lblackstone! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lblackstone, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5633
I'm not sure if all the targets I updated need that flag, but I was able to attach a debugger to the binary produced by the
kops-installtarget.