Fix build: prevent verify-misspelling failing on releases

[Mikulas]

Removes pull request subjects from release notes and checks the remainder of text.

I'd say the pull requests should be listed with the original subjects, even if they include a typo. Very likely the typos are even intentional, such as in

• [instance_groups.md] typo: recieve->receive AdamDang 5152

It lists files in docs/releases and for each release, it removes lines matching a pull request. Intentionally the files are not changed inplace, as I feel running tests should not change any files. Instead, it writes to .build/docs, because a/ it's already git ignored b/ gets cleaned with make clean

The bash is slightly more convoluted than it seemingly has to be, but it's an intentional workaround macOS sed and it's wrong behavior with -i''.

This changes the output of the misspell command, which may be confusing:

$ make verify-misspelling
./.build/docs/1.10-NOTES.md:50:28: "foo" is a misspelling of "bar"
make: *** [verify-misspelling] Error 1

Note that it says ./.build/docs/1.10-NOTES.md instead of ./docs/releases/1.10-NOTES.md

[mikesplain]

/ok-to-test

[mikesplain]

Thanks @Mikulas hmm, I'm not sure which is better, to fix the mispellings or do this...

[mikesplain]

On second review, this is great @Mikulas thanks for the quick fix!

/lgtm
/approve

[Mikulas]

@mikesplain Yeah I get that, feel free to close this if it adds too much complexity to the tests.

I honestly started this pull request by changing the release note file first, but it just made little sense to change the pull request labels. Next solution that came to mind was just skipping the 10.0 release notes altogether, but that would not fix future release notes.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, Mikulas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mikesplain]

@Mikulas This seems right to me, misspelling checking was only added a few months ago so this is our first pass on it. I agree that this, or something like it makes sense. For now, we can get this in and adjust as we go if need be. Thanks again!