AWS VPC Daemonset Correctly Tolerate Node Taints #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @mikesplain |
mikesplain
approved these changes
Aug 17, 2018
|
Thanks @benjigoldberg, looks similar enough to upstream. We have a few other updates to the cni queued up so we can handle the version bump in another pr. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjigoldberg, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks for the review @mikesplain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers!
The tolerations on the AWS VPC CNI Daemonset do not work correctly with user-provided node taints. For example, we run GPU nodes in our cluster and have node-taints so that only GPU workloads can run on these nodes. The current VPC CNI Daemonset settings do not tolerate these taints, so whenever we upgrade our cluster the CNI Pods stop running on these nodes. This patch fixes the taints so that they correctly ignore "NoSchedule" across the cluster, similar to what other CNI Daemonsets such as Weave do.