Fixes go vet complain in package upup/pkg/fi/cloudup/awstasks #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This commit fixes the result from `go vet k8s.io/kops/upup/pkg/fi/cloudup/awstasks`: upup/pkg/fi/cloudup/awstasks/iamrole.go:80: Errorf format %q has arg e.Name of wrong type *string upup/pkg/fi/cloudup/awstasks/iamrole.go:88: Errorf format %q has arg e.Name of wrong type *string upup/pkg/fi/cloudup/awstasks/iamrole.go:93: Errorf format %q has arg e.Name of wrong type *string upup/pkg/fi/cloudup/awstasks/iamrole.go:98: Errorf format %q has arg e.Name of wrong type *string upup/pkg/fi/cloudup/awstasks/iamrolepolicy.go:78: Errorf format %q has arg e.Name of wrong type *string upup/pkg/fi/cloudup/awstasks/load_balancer.go:115: Warningf format %q has arg lb.LoadBalancerName of wrong type *string upup/pkg/fi/cloudup/awstasks/load_balancer.go:328: Verbose.Info call has possible formatting directive %+v upup/pkg/fi/cloudup/awstasks/load_balancer.go:382: Verbose.Infof format %q has arg actual.LoadBalancerName of wrong type *string upup/pkg/fi/cloudup/awstasks/natgateway.go:189: Errorf format %q has arg id of wrong type *string upup/pkg/fi/cloudup/awstasks/natgateway.go:193: Verbose.Infof format %q has arg id of wrong type *string upup/pkg/fi/cloudup/awstasks/natgateway.go:197: Errorf format %q has arg id of wrong type *string upup/pkg/fi/cloudup/awstasks/natgateway.go:283: Errorf format %q has arg e.Name of wrong type *string
|
Hmm govet passes fine on master for me. We can get this testing though. /ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@mikesplain I try on go1.10.3, it doesn't complain anything but still happen on go tip. This is the output: This commit doesn't fixes on all package that go vet complain. It's only upup/pkg/fi/cloudup/awstasks. But I think it would be good if we starting fixes all of complains before go release 1.11. |
|
Got it! Cool thanks @wingyplus! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, wingyplus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.