Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fixes in stable for ci verify jobs #5737

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

chrisz100
Copy link
Contributor

@chrisz100 chrisz100 commented Sep 1, 2018

The changelog for 1.10 includes typos our vetting now marks as a bug. Cleaned the typos and annotated where something was modified in 1.10 release notes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2018
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Sep 3, 2018

@chrisz100 do we know if the CI job will just fix these once again?

@chrisz100
Copy link
Contributor Author

What do you mean fix these? As it’s just the last release and we don’t replicate this in the next release (my commit message is spelled correctly) that should be fine

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Sep 3, 2018

@chrisz100 I'm wondering if the CI bot will revert your fixes in the 1.10 changelog.

@chrisz100
Copy link
Contributor Author

Highly doubt that but possibly @justinsb knows more about these scripts?

@mikesplain
Copy link
Contributor

Hmm well these aren't really typos since they are the actual commit message and are the actual change. The CI just runs make verify-misspelling as far as I know, which passes on master for me. Where are you seeing the issue @chrisz100? Thanks for the quick fix!

@chrisz100
Copy link
Contributor Author

I don’t remember the PR ids but it’s been in quite a few pull requests.

@justinsb
Copy link
Member

This looks like a good way to fix this - thanks!

I'm looking at our verify-spelling script in more detail as well now - we were pulling from github, and it's better to vendor, so tackling that.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 46dcd5d into kubernetes:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants