Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-autoscaler.yaml for 1.10 #5741

Merged
merged 2 commits into from
Oct 2, 2018
Merged

cluster-autoscaler.yaml for 1.10 #5741

merged 2 commits into from
Oct 2, 2018

Conversation

koooge
Copy link
Contributor

@koooge koooge commented Sep 3, 2018

Hi. I use kops 1.10 with cluster autoscaler. So I tried to create yaml for 1.10.
Will you please review it?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2018
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Sep 3, 2018

@koooge has anything changed in the spec from the 1.8.0 version besides the container Image version? Doing a quick diff I did not find anything else that had changed.

@gms-ta-koge
Copy link

@rdrgmnzs apiVersion was bumped to v1.

@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2018
@koooge
Copy link
Contributor Author

koooge commented Sep 5, 2018

/assign @chrisz100

@chrisz100
Copy link
Contributor

chrisz100 commented Sep 5, 2018 •
edited
Loading

@rdrgmnzs guess updating this none the less would be a good idea. This will get stuck otherwise...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@koooge
Copy link
Contributor Author

koooge commented Sep 10, 2018

/assign @justinsb

@justinsb
Copy link
Member

justinsb commented Oct 2, 2018

Looks like the image has definitely changed, along with the RBAC, so we should get this merged!

Thanks @koooge

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb, koooge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 61e3323 into kubernetes:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@koooge @rdrgmnzs @gms-ta-koge @chrisz100 @justinsb @k8s-ci-robot