Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s-ec2-srcdst to v0.2.2 #5746

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

willthames
Copy link
Contributor

v0.2.2 fixes a bug where k8s-ec2-srcdst can crash on node deletion.

This crash causes SourceDestinationCheck to remain set to true on
nodes created after this check. Such nodes cannot talk to calico
destinations in the same subnet.

Fixes kubernetes/kubernetes#66432

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 4, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 4, 2018
@willthames
Copy link
Contributor Author

/assign @chrislovecnm

@chrisz100
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2018
@willthames
Copy link
Contributor Author

willthames commented Sep 4, 2018 via email

@mikesplain
Copy link
Contributor

This should also fix #4466

@mikesplain
Copy link
Contributor

Thanks @willthames for this, getting this fixed would be great. In order for any of these changes to be picked up you'll need to version bump the manifest here (e.g. 2.6.7-kops.3):

"k8s-1.7": "2.6.7-kops.2",

Mind making that change in the same single commit as above so it's easily traceable what the change was? Thanks!

@mikesplain
Copy link
Contributor

/assign
/unassign chrislovecnm

v0.2.2 fixes a bug where k8s-ec2-srcdst can crash on node deletion.
This crash causes SourceDestinationCheck to remain set to true on
nodes created after this check. Such nodes cannot talk to calico
destinations in the *same* subnet.

Fixes kubernetes/kubernetes#66432
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@willthames
Copy link
Contributor Author

@mikesplain done

@mikesplain
Copy link
Contributor

Great thanks so much @willthames!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, mikesplain, willthames

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6f1874a into kubernetes:master Sep 6, 2018
@willthames
Copy link
Contributor Author

Thanks @mikesplain - do you know when this will get into a 1.10 release?

@mikesplain
Copy link
Contributor

mikesplain commented Sep 6, 2018

I’m not sure, we’re working on increasing the frequency of releases. It will certainly be in 1.11 alpha. In the meantime you can certainly use our makefile to build just the cli, it should work without building additional components for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS almost entirely failing on single Kubernetes node only
5 participants