Add elasticloadbalancing:DeregisterTargets permission to master policy #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Without this permission, controller-manager gets the following error:
failed to ensure load balancer for service XXX: Error trying to
deregister targets in target group:
"AccessDenied: User: arn:aws:sts::XXX:assumed-role/masters...
is not authorized to perform: elasticloadbalancing:DeregisterTargets
on resource: arn:aws:elasticloadbalancing:XXX
kellycampbell
force-pushed
the
iam-dereg-targets
branch
from
7400d81
to
8132073
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
|
Note that this change will potentially make some of the NLB security group bugs in k8s more apparent because aws_loadbalancer.go will be able to remove sg rules where it errored out before. Hopefully those will be fixed soon. |
mikesplain
approved these changes
Sep 6, 2018
|
Thanks @kellycampbell! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, kellycampbell, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
FYI, I found and fixed the cause of one NLB security groups problem: kubernetes/kubernetes#68422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this permission, controller-manager gets the following error: