Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker 18.06.1 for Debian Stretch #5758

Merged
merged 2 commits into from
Sep 15, 2018

Conversation

granular-ryanbonham
Copy link
Contributor

Add Docker 18.06.1 - Debian Stretch..

Docker 17.03 and 17.09 have bugs that can result in pods failing to terminate due to GRPC errors and PLEG errors.. We hit both bugs after the upgrade to kubernetes 1.10.x from 1.9.x.. Upgrading to 18.06.1 in our clusters has resolved these issues, and we have seen no issues. We have been runnning 18.06.1 across 15 clusters with k8s 10.0.6.

See issue, for other reports of this.
#5747

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 6, 2018
@granular-ryanbonham
Copy link
Contributor Author

Recheck CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 6, 2018
@granular-ryanbonham
Copy link
Contributor Author

/assign @andrewsykim

@andrewsykim
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2018
@justinsb
Copy link
Member

Thanks @granular-ryanbonham - I'll read up on the underlying issue, but mapping this and allowing people to choose docker 18.06 is a good idea regardless!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, granular-ryanbonham, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 842c925 into kubernetes:master Sep 15, 2018
@loshz
Copy link

loshz commented Nov 5, 2018

Sorry to dig up old PRs, but I am regularly experiencing issues across 6 clusters with Docker 17.03.2-ce on Kubernetes v1.10.9 using kope.io/k8s-1.10-debian-jessie-amd64-hvm-ebs-2018-08-17.

How would I go about using the newer version? Is it as simple as upgrading to use Debian Stretch kope.io/k8s-1.10-debian-stretch-amd64-hvm-ebs-2018-08-17?

If someone could point me in the right direction it would be greatly appreciated 😄

@granular-ryanbonham
Copy link
Contributor Author

You need to modify your cluster yaml ``kops edit cluster``` and set the docker version

spec:
  docker:
    version: 18.06.1

@deploymentking
Copy link

@granular-ryanbonham once you have updated the cluster yaml...do you do anything other than kops update cluster name-of-cluster --yes and then kops rolling update --yes. I have tried your solution but I still seem to be stuck on 17.05

@loshz
Copy link

loshz commented Nov 13, 2018

Can confirm that this does not upgrade Docker for me either. I'm still stuck on 17.03

kops version: 1.10
k8s version: 1.10.9
ig image: k8s-1.10-debian-stretch-amd64-hvm-ebs-2018-08-17

@loshz
Copy link

loshz commented Nov 13, 2018

I just realised this PR was merged AFTER the 1.10 release, so my version of kops obviously doesn't have these changes. Could be the same problem for you @deploymentking?

@cmosetick
Copy link

Like @syscll I'm also still stuck with Docker version 17.03.2-ce.

kops version: 1.11
kubernetes version: 1.12.6
image: kope.io/k8s-1.11-debian-stretch-amd64-hvm-ebs-2018-08-17

I even baked my own AMI based on the image above that has docker version 18.06-ce in it, and created a new node instance group with the custom AMI.

When I inspect the new nodes, I still see docker version 17.03.2.

When I manually launch an instance with aws console and use the custom AMI, it has Docker version 18.06-ce.

@shahbhavik01
Copy link

shahbhavik01 commented Mar 26, 2019

Like @syscll I'm also still stuck with Docker version 17.03.2-ce.

kops version: 1.11
kubernetes version: 1.12.6
image: kope.io/k8s-1.11-debian-stretch-amd64-hvm-ebs-2018-08-17

I even baked my own AMI based on the image above that has docker version 18.06-ce in it, and created a new node instance group with the custom AMI.

When I inspect the new nodes, I still see docker version 17.03.2.

When I manually launch an instance with aws console and use the custom AMI, it has Docker version 18.06-ce.

I'm having the same issue described here as well. I have:
kops version: 1.11.1
kubernetes version 1.10.12

I have:

spec:
    docker:
        version: 18.09.3

@loshz
Copy link

loshz commented Mar 26, 2019

@cmosetick @shahbhavik01 you need to make sure you are specifying an exact Docker version that is configured in this slice, for example: 18.06.1

You must also ensure the is corresponds with the exact distro you are using, for example: Debian Stretch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants