-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker 18.06.1 for Debian Stretch #5758
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Recheck CLA |
/assign @andrewsykim |
/ok-to-test |
/lgtm |
Thanks @granular-ryanbonham - I'll read up on the underlying issue, but mapping this and allowing people to choose docker 18.06 is a good idea regardless! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, granular-ryanbonham, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry to dig up old PRs, but I am regularly experiencing issues across 6 clusters with Docker How would I go about using the newer version? Is it as simple as upgrading to use Debian Stretch If someone could point me in the right direction it would be greatly appreciated 😄 |
You need to modify your cluster yaml ``kops edit cluster``` and set the docker version
|
@granular-ryanbonham once you have updated the cluster yaml...do you do anything other than |
Can confirm that this does not upgrade Docker for me either. I'm still stuck on 17.03
|
I just realised this PR was merged AFTER the 1.10 release, so my version of kops obviously doesn't have these changes. Could be the same problem for you @deploymentking? |
Like @syscll I'm also still stuck with Docker version 17.03.2-ce.
I even baked my own AMI based on the image above that has docker version 18.06-ce in it, and created a new node instance group with the custom AMI. When I inspect the new nodes, I still see docker version 17.03.2. When I manually launch an instance with aws console and use the custom AMI, it has Docker version 18.06-ce. |
I'm having the same issue described here as well. I have: I have:
|
@cmosetick @shahbhavik01 you need to make sure you are specifying an exact Docker version that is configured in this slice, for example: You must also ensure the is corresponds with the exact distro you are using, for example: Debian Stretch. |
Add Docker 18.06.1 - Debian Stretch..
Docker 17.03 and 17.09 have bugs that can result in pods failing to terminate due to GRPC errors and PLEG errors.. We hit both bugs after the upgrade to kubernetes 1.10.x from 1.9.x.. Upgrading to 18.06.1 in our clusters has resolved these issues, and we have seen no issues. We have been runnning 18.06.1 across 15 clusters with k8s 10.0.6.
See issue, for other reports of this.
#5747