Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for Api server LB Certificate #5793

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

fernandocarletti
Copy link
Contributor

This feature was added by the PR #5414 and it is available at release 1.10.0 but there's no related documentation yet available.

This feature was added by the PR kubernetes#5414 and it is available at release 1.10.0 but there's no related documentation yet available.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2018
@mikesplain
Copy link
Contributor

Good catch @fernandocarletti! Thanks so much! I'm not as familiar with the feature, have you tested to ensure it works as you're documenting it?

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2018
@fernandocarletti
Copy link
Contributor Author

Hey @mikesplain, yes, I enabled this feature in our production cluster and this configuration example was done based on our working Load Balancer. I did a small QA (since it is our production one) and everything was ok. Kubectl and Kubernetes Dashboard were working as expected.

@mikesplain
Copy link
Contributor

Awesome, thanks @fernandocarletti!

/area documentation
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added area/documentation lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fernandocarletti, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit b0de7f5 into kubernetes:master Sep 17, 2018
@fernandocarletti fernandocarletti deleted the patch-1 branch September 17, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants