Add no_masq_local to weave network options.

[arturo-c]

This was an option that was added weave > 2.4.0 weaveworks/weave#2924 to use the k8s feature externalTrafficPolicy: Local on services to preserve the sourceIp. https://kubernetes.io/docs/tutorials/services/source-ip/

[arturo-c]

/assign @chrislovecnm

[chrisz100]

Looks good, thanks!

[chrisz100]

/ok-to-test

[KashifSaadat]

Thanks for the PR @arturo-c! Just one extra thing to change, can you bump the relevant version here (e.g. to kops.2): https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L489

This is so that the new addition in the manifest file will be picked up and updated.

[arturo-c]

@KashifSaadat done

[KashifSaadat]

Great, thanks!

/lgtm
/approve

[KashifSaadat]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arturo-c, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KashifSaadat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[denmaddog]

Hello,
When I try adding this option I get:

# Found fields that are not recognized
# ...
#     networking:
#       weave:
# +       NoMasqLocal: 1
#         mtu: 8912

 kops version
Version 1.12.2 (git-3fc9bc486)

What am I doing wrong?

Thanks,

Zeljko

[denmaddog]

forget it, I used capital N, NoMasqLocal, inzstead of noMasqLocal.

Another thing - after updating cluster, and doing rolling-update --yes, it said that no rolling update required, but I do not see in weave-net pod spec this new option, even after I delete pod and it gets re-created - any idea why?

[denmaddog]

Hello,

Even after updating cluster with this option, weave-net pods do not respect it, not in pod spec:

containers:
  - command:
    - /home/weave/launch.sh
    env:
    - name: HOSTNAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: spec.nodeName
    - name: IPALLOC_RANGE
      value: 100.96.0.0/11
    - name: WEAVE_MTU
      value: "8912"

In KOPS:

     networking:
        weave:
          noMasqLocal: 1
          mtu: 8912

ps ax|grep weave-net
16465 ?        Sl     0:00 /home/weave/weaver --port=6783 --datapath=datapath --mtu 8912 --name=6a:5f:4e:ab:28:c4 --host-root=/host --http-addr=127.0.0.1:6784 --metrics-addr=0.0.0.0:6782 --docker-api= --no-dns --db-prefix=/weavedb/weave-net --ipalloc-range=100.96.0.0/11 --nickname=ip-10-12-1-36.eu-west-1.compute.internal --ipalloc-init consensus=6 --conn-limit=100 --expect-npc 10.12.1.36 10.12.1.38 10.12.2.146 10.12.2.192 10.12.3.112 10.12.3.250

What is wrong here?