Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for max-mutating-requests-inflight parameter #5832

Merged

Conversation

captainkerk
Copy link
Contributor

@captainkerk captainkerk commented Sep 25, 2018

Adding a field as described in #5831

Thanks very much!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2018
@captainkerk captainkerk force-pushed the max-mutating-requests-inflight branch 3 times, most recently from 7867a87 to 10fdd2e Compare September 25, 2018 02:46
@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 25, 2018
@captainkerk captainkerk force-pushed the max-mutating-requests-inflight branch from 10fdd2e to beb8aeb Compare October 4, 2018 05:41
@captainkerk
Copy link
Contributor Author

captainkerk commented Oct 4, 2018

Ok, I rebased with upstream master and pushed. The e2e tests passed that time. Anything else I can do?

The end to end test rig and suite is impressive.

@justinsb
Copy link
Member

justinsb commented Oct 9, 2018

Looks great - thanks @captainkerk !

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: captainkerk, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2cfb62b into kubernetes:master Oct 9, 2018
@captainkerk captainkerk deleted the max-mutating-requests-inflight branch October 9, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants