Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity to AWS IAM Authenticator documentation #5843

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

rifelpet
Copy link
Member

Also fixed some markdown link formatting. This is related to kubernetes-sigs/aws-iam-authenticator#135

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2018
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks so much @rifelpet!

/lgtm
/approve
/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2018
@rifelpet
Copy link
Member Author

/retest

3 similar comments
@rifelpet
Copy link
Member Author

/retest

@rifelpet
Copy link
Member Author

/retest

@rifelpet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d95f0e2 into kubernetes:master Sep 28, 2018
@rifelpet rifelpet deleted the aws_iam_docs branch April 25, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants