Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Weave Net to version 2.4.1 #5845

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

bboreham
Copy link
Contributor

Includes bug fixes to the deleted-node cleanup code. Those bugs have hit people with auto-scaling groups that go up and down - definitely a recommended update in this case.

Release notes https://github.com/weaveworks/weave/releases/tag/v2.4.1

Includes bug fixes to the deleted-node cleanup code.
Release notes https://github.com/weaveworks/weave/releases/tag/v2.4.1

Signed-off-by: Bryan Boreham <bryan@weave.works>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2018
@Raffo
Copy link
Contributor

Raffo commented Oct 6, 2018

Hi @bboreham, thanks for the PR! I'm not sure if we can consider the bugs fixed as users are reporting them as not fixed as in weaveworks/weave#3300 . I will ran the tests again next week and report here to see if we should go on integrating this PR or wait for additional fixes.

@bboreham
Copy link
Contributor Author

bboreham commented Oct 6, 2018

Those users are talking about a minor issue causing nothing more than some noise in the logs.
This is trivial compared to the race conditions that were fixed.

@Raffo
Copy link
Contributor

Raffo commented Oct 6, 2018 via email

@justinsb
Copy link
Member

justinsb commented Oct 9, 2018

Thanks @bboreham - we need to bump the version in bootstrapchannelbuilder also, but I'll send a PR to do that

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bboreham, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit cd3de8e into kubernetes:master Oct 9, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
@azman0101
Copy link
Contributor

Is this PR a candidate for cherry-pick for a kops 1.10.1 version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants