Controller Manager Flag #5855
Merged
Controller Manager Flag #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gambol99
commented
Oct 1, 2018
gambol99
commented
- adding the controller manager flag as this default to bootstrapsigner, tokencleaner disabled
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
- adding the controller manager flag as this default to bootstrapsigner, tokencleaner disabled
gambol99
force-pushed
the
controllers_flag
branch
from
27cb738
to
806b0cb
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm Cheers @gambol99 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, KashifSaadat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-kubernetes-aws |
|
@KashifSaadat ... I'm just double checking if this is a e2e error or a error I've introduced .. |
$ kubectl get no
NAME STATUS ROLES AGE VERSION
ip-10-250-100-229.eu-west-2.compute.internal Ready node 1m v1.10.3
ip-10-250-101-77.eu-west-2.compute.internal Ready node 1m v1.10.3
ip-10-250-31-15.eu-west-2.compute.internal Ready master 3m v1.10.3
ip-10-250-32-151.eu-west-2.compute.internal Ready master 3m v1.10.3
ip-10-250-33-83.eu-west-2.compute.internal Ready master 3m v1.10.3ok .. i'm guessing an e2e issue .. rerunning tests |
|
/test pull-kops-e2e-kubernetes-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.