Follow on for #5744 #5862
Merged
Follow on for #5744 #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
If we skip it, we can't test it. We do expect that most users will use a lifecycle that only warns though.
Fixes the case where we mix use of specified & default SGs.
e.g. each master SGs need to be configured to talk to each master SG
This ensures we are consistently naming our rules
Also add comments about why we don't set e.g. RemoveExtraRules
justinsb
force-pushed
the
follow_on_5744
branch
from
b02608f
to
81cadec
Compare
|
cc @rdrgmnzs |
|
/test pull-kops-e2e-kubernetes-aws |
|
Thanks for the cleanup @justinsb /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-kubernetes-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some cases where users mix security groups in a role, or mix
override & default security groups.