Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating image and docs for metrics-server add-on #5873

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Updating image and docs for metrics-server add-on #5873

merged 1 commit into from
Nov 17, 2018

Conversation

Cryptophobia
Copy link
Contributor

@Cryptophobia Cryptophobia commented Oct 4, 2018

Updating image to v0.3.1 and adding more information to README on custom args. All this is the latest info from https://github.com/kubernetes-incubator/metrics-server/

EDIT: Changed image from k8s.gcr.io/metrics-server-amd64:v0.3.1 to gcr.io/google_containers/metrics-server-amd64:v0.3.1 as that is the official location of the production helm chart images.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2018
@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 4, 2018
@Cryptophobia
Copy link
Contributor Author

Changed image from k8s.gcr.io/metrics-server-amd64:v0.3.1 to gcr.io/google_containers/metrics-server-amd64:v0.3.1 as that is the official location of the production helm chart images.

@justinsb
Copy link
Member

Thanks @Cryptophobia

Question though - I think the images are supposed to be k8s.gcr.io - where are you seeing that the official image is something different?

@justinsb
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cryptophobia, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 64959b2 into kubernetes:master Nov 17, 2018
@Cryptophobia
Copy link
Contributor Author

Cryptophobia commented Nov 18, 2018

Thanks @Cryptophobia

Question though - I think the images are supposed to be k8s.gcr.io - where are you seeing that the official image is something different?

Hey @justinsb,
Originally, the images from the kubernetes-incubator organization deployment were used and they are found at k8s.gcr.io. You can find the images defined here.

However, after looking at the official helm repo (non-k8s-incubator) for the metrics-server, I noticed that the images were the same versions and they can be found on gcr.io/google_containers/metrics-server-amd64. You can find the images defined in the deployment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants