-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating image and docs for metrics-server add-on #5873
Updating image and docs for metrics-server add-on #5873
Conversation
/ok-to-test |
Changed image from |
Thanks @Cryptophobia Question though - I think the images are supposed to be k8s.gcr.io - where are you seeing that the official image is something different? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cryptophobia, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @justinsb, However, after looking at the official helm repo (non-k8s-incubator) for the metrics-server, I noticed that the images were the same versions and they can be found on |
Updating image to
v0.3.1
and adding more information to README on custom args. All this is the latest info from https://github.com/kubernetes-incubator/metrics-server/EDIT: Changed image from
k8s.gcr.io/metrics-server-amd64:v0.3.1
togcr.io/google_containers/metrics-server-amd64:v0.3.1
as that is the official location of the production helm chart images.