Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add targetRamMb to kubeAPIServer spec #5890

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

captainkerk
Copy link
Contributor

This PR adds support for setting targetRamMb in the kube apiserver spec

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2018
@captainkerk
Copy link
Contributor Author

The travis build is failing on make gen-cli-docs, which is failing on master as well. I'm happy to add it to this PR, though I suppose that deserves its own PR.

@justinsb
Copy link
Member

justinsb commented Oct 9, 2018

Sorry, the make gen-cli-docs is because I temporarily broke master trying getting some old docs prs merged - ignore it and I'll force-merge once it's only travis failing.

I'm was just debating how we should name the flag - Mb or MB. We haven't been very consistent about resources in flags...

I think Mb is both more correct and more consistent, therefore...

/approve
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: captainkerk, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@justinsb
Copy link
Member

justinsb commented Oct 9, 2018

Manually merging because all tests but travis have passed, and travis failure is known problem with master (since resolved).

@justinsb justinsb merged commit 26ed46e into kubernetes:master Oct 9, 2018
@captainkerk
Copy link
Contributor Author

Thank you Justin!

@captainkerk captainkerk deleted the add-target-ram-mb-option branch October 9, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants