Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amazon-vpc-routed-eni to v1.2.1 #5905

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

adammw
Copy link
Contributor

@adammw adammw commented Oct 9, 2018

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2018
@adammw adammw force-pushed the adammw/update-aws-cni-1.2.0 branch from 44a5824 to cbc233a Compare October 9, 2018 23:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2018
@chrisz100
Copy link
Contributor

/ok-to-test

Thanks for signing the CLA!

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2018
@adammw
Copy link
Contributor Author

adammw commented Oct 10, 2018

Turns out there is a bug in 1.2.0 that will be fixed in an upcoming release that will cause problems for people upgrading from 1.0.0: aws/amazon-vpc-cni-k8s#188

@rdrgmnzs
Copy link
Contributor

@adammw looks like 1.2.1 was released which fixes the issue you mentioned. Mind bumping the version?

@adammw adammw force-pushed the adammw/update-aws-cni-1.2.0 branch from cbc233a to a737a1b Compare October 16, 2018 22:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@adammw adammw changed the title Update amazon-vpc-routed-eni to v1.2.0 Update amazon-vpc-routed-eni to v1.2.1 Oct 16, 2018
@adammw
Copy link
Contributor Author

adammw commented Oct 16, 2018

@chrisz100 updated to 1.2.1 which appears to work without any extra CRDs.

@justinsb
Copy link
Member

Thanks @adammw !

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adammw, chrisz100, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit ea97194 into kubernetes:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants