Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canal Manifest Fix (Kubernetes >= v1.12.0) #5910

Merged
merged 1 commit into from
Oct 10, 2018

Commits on Oct 10, 2018

  1. Canal Manifest Fix (Kubernetes >= v1.12.0)

    So the current canal manifest contains a 'description' field which as far as I can tell from the API documentation never existed (in apimachinery). Previous versions probably ignored the field but while testing v1.12.1 I noticed canal no longer deployed correctly due to the validation error. I've bumped the versions and removed the field from the manifest; this shouldn't have any impact on those already deployed, but as an alternative we could copy and paste 1.8 manifest, add an exclusion in the [bootstrapchannelbuilder.go](https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go#L685-L699) to use >1.8.0 <=1.12.0 etc and use new manifest for >=1.12.0 (if you get what i know :-))
    
    Post removing the `description` field the networking works again ..
    gambol99 committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    d1ea6ad View commit details
    Browse the repository at this point in the history