Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: lazy-evaluate encryption policy #5921

Merged

Conversation

justinsb
Copy link
Member

Should help performance a little bit, and should be a little faster.

Should help performance a little bit, and should be a little faster.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2018
@rdrgmnzs
Copy link
Contributor

Thanks @justinsb

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3a58c92 into kubernetes:master Oct 11, 2018
@xanonid
Copy link

xanonid commented Oct 25, 2018

Could it be, that the master IAM S3 Bucket Policy needs to be adapted? We get Access Denied warnings since upgrade to kops 1.10 related to access to GetBucketEncryption of the kops bucket. The master policy allows only GetBucketLocation and ListBucket.

The needed permission is called s3:GetEncryptionConfiguration.

@rdrgmnzs
Copy link
Contributor

@xanonid could you open an issue for this if you have not done so already. It would also be really helpful if possible to include the entire error/warning output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants