Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPVS Options #5935

Merged
merged 2 commits into from
Oct 15, 2018
Merged

IPVS Options #5935

merged 2 commits into from
Oct 15, 2018

Conversation

gambol99
Copy link
Contributor

  • adding the additional ipvs options to the kube proxy configuration
  • adding a basic check in the network cidrs supplied

@gambol99
IPVS Options
380cadd 
- adding the additional ipvs options to the kube proxy configuration
@gambol99
- adding a basic check in the network cidrs supplied
dd43b1b
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2018
@rdrgmnzs
Copy link
Contributor

This should be safe as it adds a few options however does not set any of the defaults.

Thanks @gambol99

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a26079 into kubernetes:master Oct 15, 2018
@gambol99 gambol99 deleted the ipvs_options branch February 22, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rdrgmnzs rdrgmnzs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gambol99 @rdrgmnzs @k8s-ci-robot @chrisz100