Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in files #5944

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix typos in files #5944

merged 1 commit into from
Oct 15, 2018

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Oct 14, 2018

Fix typos in files:

  1. cmd/kops/get_instancegroups.go
  2. dnsprovider/pkg/dnsprovider/providers/aws/route53/interface.go
  3. pkg/model/pki.go

@mooncak
Fix typos in files
d75dc27 
Signed-off-by: mooncake <xcoder@tenxcloud.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Oct 14, 2018

/assign @geojaz

chrisz100
chrisz100 approved these changes Oct 14, 2018
View reviewed changes
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2018
@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2018
mikesplain
mikesplain approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mooncak!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, mikesplain, mooncak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3c61f40 into kubernetes:master Oct 15, 2018
@mooncak mooncak deleted the fix_pkg_issue branch November 4, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@mikesplain mikesplain mikesplain approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@chrisz100 chrisz100

@mikesplain mikesplain

@geojaz geojaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mooncak @chrisz100 @k8s-ci-robot @mikesplain @geojaz