Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cn-northwest-1c. #5956

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Add support for cn-northwest-1c. #5956

merged 1 commit into from
Oct 20, 2018

Conversation

leeeboo
Copy link
Contributor

@leeeboo leeeboo commented Oct 17, 2018

Add support for cn-northwest-1c (a new az in cn-northwest-1).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2018
@k8s-ci-robot
Copy link
Contributor

@leeeboo: GitHub didn't allow me to assign the following users: Thanks.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @gambol99 Thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leeeboo
Copy link
Contributor Author

leeeboo commented Oct 17, 2018

/assign @gambol99

@chrisz100
Copy link
Contributor

/ok-to-test

Thanks @leeeboo !

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2018
@justinsb
Copy link
Member

/approve
/lgtm

Thanks @leeeboo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, leeeboo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 50800d8 into kubernetes:master Oct 20, 2018
@leeeboo
Copy link
Contributor Author

leeeboo commented Oct 22, 2018

@justinsb Thank you

2 similar comments
@leeeboo
Copy link
Contributor Author

leeeboo commented Oct 22, 2018

@justinsb Thank you

@leeeboo
Copy link
Contributor Author

leeeboo commented Oct 22, 2018

@justinsb Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leeeboo @k8s-ci-robot @chrisz100 @justinsb @gambol99