Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Fix Prometheus serve addr flag #5987

Merged
merged 1 commit into from
Oct 27, 2018
Merged

cilium: Fix Prometheus serve addr flag #5987

merged 1 commit into from
Oct 27, 2018

Conversation

rochacon
Copy link
Contributor

While checking for Cilium customization flags I've noticed this incorrect flag in the template.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2018
@ihoegen
Copy link
Contributor

ihoegen commented Oct 23, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2018
@ihoegen
Copy link
Contributor

ihoegen commented Oct 23, 2018

Thanks for your contribution!

@justinsb
Copy link
Member

Ooops! Thanks @rochacon !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ihoegen, justinsb, rochacon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3ce38ca into kubernetes:master Oct 27, 2018
@rochacon rochacon deleted the patch-1 branch October 29, 2018 22:28
@oxyno-zeta
Copy link

Hello,

Any backport for kops 1.10 ?

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@ihoegen ihoegen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rochacon @ihoegen @justinsb @k8s-ci-robot @oxyno-zeta