Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #6013

Merged
merged 1 commit into from
Nov 9, 2018
Merged

fix some typos #6013

merged 1 commit into from
Nov 9, 2018

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Oct 29, 2018

Fixed some typos.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Oct 29, 2018

/assign @geojaz

@idealhack
Copy link
Member

idealhack commented Oct 29, 2018 •
edited
Loading

Please combine multiple trivial fixes in one PR to save reviewers time. Read more here.

@chrisz100
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Nov 2, 2018

/assign @justinsb

@SataQiu
Copy link
Member Author

SataQiu commented Nov 4, 2018

/assign @geojaz

@justinsb
Copy link
Member

justinsb commented Nov 9, 2018

Thanks @SataQiu

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 451b846 into kubernetes:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@justinsb justinsb

@chrisz100 chrisz100

@geojaz geojaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SataQiu @idealhack @chrisz100 @justinsb @k8s-ci-robot @geojaz